[llvm-commits] Fix output stream opened in text instead of binary mode on MinGW

[Jakob Stoklund Olesen]

On Nov 24, 2010, at 9:07 AM, Danil Malyshev wrote:

Hi Danil,

Thanks for working on this.

> 1. Adds support for setw() method to the llvm::raw_ostream.

Please don't do that, though. Part of the idea behind raw_ostream is that it doesn't have any of the overhead from formatting and so on.

Can you find a way of doing this without increasing the size of the raw_ostream object, and without imposing any overhead on users that don't need it?

Thanks,
/jakob

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20101127/898716ee/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 1929 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20101127/898716ee/attachment.bin>