[llvm-commits] [patch] Use .loc in codegen

[Devang Patel]

On Nov 17, 2010, at 3:04 PM, Rafael Espíndola wrote:

>> Note, this patch relies on fresh .loc/.file support by MCStreamer.
> 
> That is the idea :-)
> 
>> First, we need gdb testsuite results with and without this patch to ensure correctness of debug info. Can you get numbers for your platform (using clang as the compiler)?
>> 
> 
> An initial run found problems with files that use "#line". The
> attached patch fixes that. Results using
> 7850396a466baacc66a0bea032a62e3292d1f45c from
> git://sourceware.org/git/gdb.git and llvm/clang 119577.
> 
> gcc 4.4.3-4ubuntu5:
> # of expected passes            16500
> # of unexpected failures        21
> # of expected failures          90
> # of untested testcases         9
> # of unsupported tests          74
> 
> Without this patch:
> 
> # of expected passes            14155
> # of unexpected failures        1125
> # of unexpected successes       4
> # of expected failures          58
> # of untested testcases         50
> # of unresolved testcases       8
> # of unsupported tests          78
> 
> With this patch:
> 
> # of expected passes            14161
> # of unexpected failures        1119
> # of unexpected successes       4
> # of expected failures          58
> # of untested testcases         50
> # of unresolved testcases       8
> # of unsupported tests          78
> 
> Looks like this patch also gives us more passes :-)
> 
> I have also attached the test summaries.

Thanks! Go ahead and please apply your patch. 

Please make sure that we include this change in next LLVM release note. Here we are assuming that all supported platforms'  assembler supports .loc/.file, which is ok.

-
Devang