[llvm-commits] [llvm] r119462 - in /llvm/trunk/lib/Target/ARM: ARMAsmBackend.cpp ARMTargetMachine.cpp

Chris Lattner sabre at nondot.org
Tue Nov 16 21:41:32 PST 2010


Author: lattner
Date: Tue Nov 16 23:41:32 2010
New Revision: 119462

URL: http://llvm.org/viewvc/llvm-project?rev=119462&view=rev
Log:
tidy up

Modified:
    llvm/trunk/lib/Target/ARM/ARMAsmBackend.cpp
    llvm/trunk/lib/Target/ARM/ARMTargetMachine.cpp

Modified: llvm/trunk/lib/Target/ARM/ARMAsmBackend.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/ARM/ARMAsmBackend.cpp?rev=119462&r1=119461&r2=119462&view=diff
==============================================================================
--- llvm/trunk/lib/Target/ARM/ARMAsmBackend.cpp (original)
+++ llvm/trunk/lib/Target/ARM/ARMAsmBackend.cpp Tue Nov 16 23:41:32 2010
@@ -22,15 +22,12 @@
 #include "llvm/Support/ErrorHandling.h"
 #include "llvm/Support/raw_ostream.h"
 #include "llvm/Target/TargetRegistry.h"
-#include "llvm/Target/TargetAsmBackend.h"
 using namespace llvm;
 
 namespace {
 class ARMAsmBackend : public TargetAsmBackend {
 public:
-  ARMAsmBackend(const Target &T)
-    : TargetAsmBackend(T) {
-  }
+  ARMAsmBackend(const Target &T) : TargetAsmBackend(T) {}
 
   bool MayNeedRelaxation(const MCInst &Inst) const;
 
@@ -42,6 +39,7 @@
     return 4;
   }
 };
+} // end anonymous namespace
 
 bool ARMAsmBackend::MayNeedRelaxation(const MCInst &Inst) const {
   // FIXME: Thumb targets, different move constant targets..
@@ -64,7 +62,6 @@
     OW->Write8(0);
   return true;
 }
-} // end anonymous namespace
 
 namespace {
 // FIXME: This should be in a separate file.
@@ -105,13 +102,12 @@
   assert(0 && "ELFARMAsmBackend::ApplyFixup() unimplemented");
 }
 
+namespace {
 // FIXME: This should be in a separate file.
 class DarwinARMAsmBackend : public ARMAsmBackend {
   MCMachOObjectFormat Format;
-
 public:
-  DarwinARMAsmBackend(const Target &T)
-    : ARMAsmBackend(T) {
+  DarwinARMAsmBackend(const Target &T) : ARMAsmBackend(T) {
     HasScatteredSymbols = true;
   }
 
@@ -140,6 +136,7 @@
     return false;
   }
 };
+} // end anonymous namespace
 
 static unsigned getFixupKindNumBytes(unsigned Kind) {
   switch (Kind) {

Modified: llvm/trunk/lib/Target/ARM/ARMTargetMachine.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/ARM/ARMTargetMachine.cpp?rev=119462&r1=119461&r2=119462&view=diff
==============================================================================
--- llvm/trunk/lib/Target/ARM/ARMTargetMachine.cpp (original)
+++ llvm/trunk/lib/Target/ARM/ARMTargetMachine.cpp Tue Nov 16 23:41:32 2010
@@ -34,13 +34,12 @@
 // This is duplicated code. Refactor this.
 static MCStreamer *createMCStreamer(const Target &T, const std::string &TT,
                                     MCContext &Ctx, TargetAsmBackend &TAB,
-                                    raw_ostream &_OS,
-                                    MCCodeEmitter *_Emitter,
+                                    raw_ostream &OS,
+                                    MCCodeEmitter *Emitter,
                                     bool RelaxAll) {
-  Triple TheTriple(TT);
-  switch (TheTriple.getOS()) {
+  switch (Triple(TT).getOS()) {
   case Triple::Darwin:
-    return createMachOStreamer(Ctx, TAB, _OS, _Emitter, RelaxAll);
+    return createMachOStreamer(Ctx, TAB, OS, Emitter, RelaxAll);
   case Triple::MinGW32:
   case Triple::MinGW64:
   case Triple::Cygwin:
@@ -48,7 +47,7 @@
     llvm_unreachable("ARM does not support Windows COFF format");
     return NULL;
   default:
-    return createELFStreamer(Ctx, TAB, _OS, _Emitter, RelaxAll);
+    return createELFStreamer(Ctx, TAB, OS, Emitter, RelaxAll);
   }
 }
 
@@ -62,22 +61,16 @@
   RegisterAsmInfoFn B(TheThumbTarget, createMCAsmInfo);
 
   // Register the MC Code Emitter
-  TargetRegistry::RegisterCodeEmitter(TheARMTarget,
-                                      createARMMCCodeEmitter);
-  TargetRegistry::RegisterCodeEmitter(TheThumbTarget,
-                                      createARMMCCodeEmitter);
+  TargetRegistry::RegisterCodeEmitter(TheARMTarget, createARMMCCodeEmitter);
+  TargetRegistry::RegisterCodeEmitter(TheThumbTarget, createARMMCCodeEmitter);
 
   // Register the asm backend.
-  TargetRegistry::RegisterAsmBackend(TheARMTarget,
-                                     createARMAsmBackend);
-  TargetRegistry::RegisterAsmBackend(TheThumbTarget,
-                                     createARMAsmBackend);
+  TargetRegistry::RegisterAsmBackend(TheARMTarget, createARMAsmBackend);
+  TargetRegistry::RegisterAsmBackend(TheThumbTarget, createARMAsmBackend);
 
   // Register the object streamer.
-  TargetRegistry::RegisterObjectStreamer(TheARMTarget,
-                                         createMCStreamer);
-  TargetRegistry::RegisterObjectStreamer(TheThumbTarget,
-                                         createMCStreamer);
+  TargetRegistry::RegisterObjectStreamer(TheARMTarget, createMCStreamer);
+  TargetRegistry::RegisterObjectStreamer(TheThumbTarget, createMCStreamer);
 
 }
 





More information about the llvm-commits mailing list