[llvm-commits] [llvm] r119149 - /llvm/trunk/lib/MC/ELFObjectWriter.cpp

Rafael EspĂ­ndola rafael.espindola at gmail.com
Mon Nov 15 08:52:13 PST 2010

On 15 November 2010 11:18, Jason W Kim <jason.w.kim.2009 at gmail.com> wrote:
> Author: jasonwkim
> Date: Mon Nov 15 10:18:39 2010
> New Revision: 119149
> URL: http://llvm.org/viewvc/llvm-project?rev=119149&view=rev
> Log:
> Dovetail with Dan Dunbar's rework of ELFObjectWriter.
> Added 2 new subclasses - X86ELFObjectWriter and ARMELFObectWriter.
> ARM and X86 require different code for RecordRelocation(), possibly others.


Only comment is that it is probably better to make methods virtual as needed.

One day we might want to move RecordRelocation to lib/Target, but for
now it is better to keep it here so that we see any potential for code


More information about the llvm-commits mailing list