[llvm-commits] [PATCH] Object File Library

Michael Spencer bigcheesegs at gmail.com
Sun Nov 14 15:54:53 PST 2010


2010/11/14 Rafael EspĂ­ndola <rafael.espindola at gmail.com>:
> On 11 November 2010 21:23, Michael Spencer <bigcheesegs at gmail.com> wrote:
>> Attached are updated patches to be reviewed. I've split them up into
>> the generic API, the COFF and ELF implementations, tool changes, and
>> tests.
>
> I hope you don't mind if at some point I move the basic ELF types from
> lib/Object/ELFObjectFile.cpp to a header file. I would *love* to use
> them in ELFObjectWriter.cpp :-)
>
>>
>> - Michael Spencer
>
> Thanks a lot,
> Rafael
>

I have no problem with that. The only thing I don't like about them
currently is the super typedef macro I had to add to avoid adding 14
lines of typedefs in each templated class :(.

Oh, and I haven't decided how to add writing to
packed_endian_specific_integral yet. Currently it's not possible
(without reinterpret_cast).

- Michael Spencer




More information about the llvm-commits mailing list