[llvm-commits] [llvm] r119064 - /llvm/trunk/CMakeLists.txt

[Oscar Fuentes]

Frits van Bommel <fvbommel at gmail.com> writes:

> On Sun, Nov 14, 2010 at 9:15 PM, Oscar Fuentes <ofv at wanadoo.es> wrote:
>> Author: ofv
>> Date: Sun Nov 14 14:15:05 2010
>> New Revision: 119064
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=119064&view=rev
>> Log:
>> CMakeLists.txt: removed mismatched endif predicate.
>
> That was not the only problem with that code:
> http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20101108/111728.html

Thanks for the heads up.

> Since this commit conflicts with the patch I attached there, here's a new one.

-  if( EXISTS ${LLVM_MAIN_SRC_DIR}/lib/Target/${t}/*AsmPrinter.cpp )
+  file(GLOB ASMPRINTER_FILE ${LLVM_MAIN_SRC_DIR}/lib/Target/${t}/*AsmPrinter.cpp )
+  if( EXISTS ${ASMPRINTER_FILE} )

This is 100% right either. In the case where zero or more than one files
matches the glob expression, the semantics of if( EXISTS ... ) is not
well defined. I'll commit a fix ASAP.