[llvm-commits] [llvm] r118938 - in /llvm/trunk/lib/Target/ARM: ARMCodeEmitter.cpp ARMExpandPseudoInsts.cpp ARMInstrInfo.cpp ARMInstrInfo.h ARMInstrInfo.td

[Evan Cheng]

On Nov 12, 2010, at 4:04 PM, Chris Lattner wrote:

> 
> On Nov 12, 2010, at 3:03 PM, Evan Cheng wrote:
> 
>> Author: evancheng
>> Date: Fri Nov 12 17:03:38 2010
>> New Revision: 118938
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=118938&view=rev
>> Log:
>> Eliminate ARM::MOVi2pieces. Just use MOVi32imm and expand it to either movi+orr or movw+movt depending on the subtarget.
> 
> Ok.
> 
>> +        unsigned SOImmValV1 = ARM_AM::getSOImmTwoPartFirst(ImmVal);
>> +        unsigned SOImmValV2 = ARM_AM::getSOImmTwoPartSecond(ImmVal);
>> +        LO16 = LO16.addImm(SOImmValV1);
>> +        HI16 = HI16.addImm(SOImmValV2);
>> +        (*LO16).setMemRefs(MI.memoperands_begin(), MI.memoperands_end());
>> +        (*HI16).setMemRefs(MI.memoperands_begin(), MI.memoperands_end());
> 
> Please use x-> instead of (*x).

To be fixed. MachineInstrBuilder doesn't have -> operator.

Evan

> 
> -Chris