[llvm-commits] [PATCH][System/Path] Update comments to match code.

[Michael Spencer]

2010/11/9 Rafael Espíndola <rafael.espindola at gmail.com>:
> On 8 November 2010 20:49, Michael Spencer <bigcheesegs at gmail.com> wrote:
>> Neither the Unix or Windows implementation include
>> LLVM_LIB_SEARCH_PATH. I'm assuming the comments are wrong. Just making
>> sure it's not the code that is wrong.
>
> Probably a cut and paste error,GetBitcodeLibraryPaths uses that variable.
> The only indirect user I can find is in llvm-ld. Maybe we could move
> this stuff there?

I think it's fine where it is for the bitcode. If anyone else uses it
in the future it would be better for LLVM_LIB_SEARCH_PATH to work
correctly. I'll update the comment for the system libs.

- Michael Spencer

>> Also, the Windows implementation is completely wrong on a multitude of
>> levels. It should be using SHGetFolderPath instead of hard coding
>> C:\Windows, and none of those directories contain any libraries that
>> are actually used on modern Windows.
>>
>> What is the actual purpose of this function? To get libraries for link
>> time or runtime? If it's for link time then what we really want is the
>> platform sdk and MSVC directories, or something else on MinGW. If it's
>> for runtime then... well... take your pick. There are quite a few
>> directories depending on the OS version, Architecture, etc... And then
>> there's MinGW.
>>
>> - Michael Spencer
>
>
> Cheers,
> Rafael
>