[llvm-commits] [Review request] test: Add the new feature "loadable_module"

[Rafael Espíndola]

On 21 October 2010 03:51, NAKAMURA Takumi <geek4civic at gmail.com> wrote:
> Hello.
>
> Cygming can build Module.dll for Opt and Bugpoint with autoconf.

I think these patches are fine. Do the generated modules work on
windows? I had the impression that on windowns plugins could not
access symbols from the main executable.

> I will propose two patches attached. Please give me comments.
>
>
> * 0001 - Add the feature "loadable_module"
>
> By default, "loadable_module" is 1.
> On cygwin and win32(s), it obeys ENABLE_SHARED.
>
> It should not have any sideeffects, I believe.
>
>
> * 0002 - patches for 4 tests
>
> Without "loadable_module", all of 4 tests marks as "UNSUPPORTED".
>
> I have confirmed (both enable_shared) on CentOS5, Cygwin and Mingw.
>
> I have confirmed with cmake on Mingw.
> IIRC, cmake/mingw and cmake/msvc set ENABLE_SHARED as '0'.
> I believe it might not affect msvc buildbots.
>
>
> ps. LLVMHello.dll can be built manually :)
> (or seek llvmdev or here with "llvmhello")
>
>
> Enjoy happy testing, ...Takumi
>

Cheers,
Rafael