[llvm-commits] [PATCH][System/Path] Update comments to match code.

[Michael Spencer]

Neither the Unix or Windows implementation include
LLVM_LIB_SEARCH_PATH. I'm assuming the comments are wrong. Just making
sure it's not the code that is wrong.

Also, the Windows implementation is completely wrong on a multitude of
levels. It should be using SHGetFolderPath instead of hard coding
C:\Windows, and none of those directories contain any libraries that
are actually used on modern Windows.

What is the actual purpose of this function? To get libraries for link
time or runtime? If it's for link time then what we really want is the
platform sdk and MSVC directories, or something else on MinGW. If it's
for runtime then... well... take your pick. There are quite a few
directories depending on the OS version, Architecture, etc... And then
there's MinGW.

- Michael Spencer
-------------- next part --------------
A non-text attachment was scrubbed...
Name: update-comments-to-match-code.patch
Type: application/octet-stream
Size: 978 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20101108/1aef8f23/attachment.obj>