[llvm-commits] [llvm] r117646 - /llvm/trunk/unittests/CMakeLists.txt

[Óscar Fuentes]

Michael Spencer <bigcheesegs at gmail.com> writes:

>> r116834 stablished LLVM_REQUIRE_RTTI to 1 on unittests/CMakeLists.txt:
>>
>> commit 1ac44a341aecac2c5329957bbe72487a3ad8aa14
>> Author: mspencer
>> Date:   Tue Oct 19 18:04:19 2010 +0000
>>
>>    unittests: Use the correct defines and global variables when building on CMake.
>>
>>    git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@116834 91177308-0d34-0410-b5e6-96231b3b80d8
>>
>> --- a/unittests/CMakeLists.txt
>> +++ b/unittests/CMakeLists.txt
>> @@ -13,6 +13,8 @@ function(add_llvm_unittest test_name)
>>  endfunction()
>>
>>  include_directories(${LLVM_MAIN_SRC_DIR}/utils/unittest/googletest/include)
>> +set(LLVM_REQUIRES_RTTI 1)
>> +add_definitions(-DGTEST_HAS_RTTI=0)
>>
>>  set(LLVM_LINK_COMPONENTS
>>   jit
>>
>>
>> I asked for a clarification about the purpose of that change, with no luck.
>
> I made this change because you changed utils/unittest/CMakeLists.txt.
> They must remain in sync.

Thanks for the explanation. However, Takumi's change reverts your
assignment to LLVM_REQUIRES_RTTI, for fixing a build issue, so either
the synchronization is not strictly required, or there is a deeper issue
here.

[snip]