[llvm-commits] Peephole infrastructure RFC (issue2781041)

ggreif at gmail.com ggreif at gmail.com
Fri Oct 29 01:10:13 PDT 2010


Add Comments stated by Bill Wendling.


http://codereview.appspot.com/2781041/diff/1/lib/Target/ARM/ARMBaseInstrInfo.cpp
File lib/Target/ARM/ARMBaseInstrInfo.cpp (left):

http://codereview.appspot.com/2781041/diff/1/lib/Target/ARM/ARMBaseInstrInfo.cpp#oldcode1495
lib/Target/ARM/ARMBaseInstrInfo.cpp:1495:
llvm::next(MachineBasicBlock::iterator(MI)));
Bill's comment: leave this as llvm::next as it may conflict with
std::next on some existing compilers

http://codereview.appspot.com/2781041/diff/1/lib/Target/ARM/ARMBaseInstrInfo.cpp
File lib/Target/ARM/ARMBaseInstrInfo.cpp (right):

http://codereview.appspot.com/2781041/diff/1/lib/Target/ARM/ARMBaseInstrInfo.cpp#newcode1488
lib/Target/ARM/ARMBaseInstrInfo.cpp:1488:
optimizeWith<MaskRegOpportunity,
indentation!

http://codereview.appspot.com/2781041/diff/1/lib/Target/ARM/ARMBaseInstrInfo.cpp#newcode1751
lib/Target/ARM/ARMBaseInstrInfo.cpp:1751: CopyEquiv
c1(TST->getOperand(0).getReg());
bad indentation

http://codereview.appspot.com/2781041/



More information about the llvm-commits mailing list