[llvm-commits] [llvm] r117420 - in /llvm/trunk: cmake/modules/ lib/Target/MBlaze/ lib/Target/MBlaze/AsmParser/ lib/Target/MBlaze/Disassembler/

Anton Korobeynikov anton at korobeynikov.info
Wed Oct 27 01:38:49 PDT 2010


Hello Wesley,

> +  // Get the MCInst opcode from the binary instruction and make sure
> +  // that it is a valid instruction.
> +  unsigned opcode = getOPCODE( insn );
> +  if( opcode == UNSUPPORTED )
> +    return false;
Could you please use the consistent code style in the files? E.g. no
spaces after "(" and before ")",
space before "(", etc.

Thanks!
-- 
With best regards, Anton Korobeynikov
Faculty of Mathematics and Mechanics, Saint Petersburg State University




More information about the llvm-commits mailing list