[llvm-commits] [llvm] r117061 - /llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp

[Michael J. Spencer]

Author: mspencer
Date: Thu Oct 21 15:49:23 2010
New Revision: 117061

URL: http://llvm.org/viewvc/llvm-project?rev=117061&view=rev
Log:
X86: Base _fltused on the FunctionType of the called value instead of the potentially null "CalledFunction". Thanks Duncan!

This is needed for indirect calls.

Modified:
    llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp

Modified: llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp?rev=117061&r1=117060&r2=117061&view=diff
==============================================================================
--- llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp (original)
+++ llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp Thu Oct 21 15:49:23 2010
@@ -5010,6 +5010,26 @@
     return;
   }
 
+  // See if any floating point values are being passed to this function. This is
+  // used to emit an undefined reference to fltused on Windows.
+  const FunctionType *FT =
+    cast<FunctionType>(I.getCalledValue()->getType()->getContainedType(0));
+  MachineModuleInfo &MMI = DAG.getMachineFunction().getMMI();
+  if (FT->isVarArg() &&
+      !MMI.callsExternalVAFunctionWithFloatingPointArguments()) {
+    for (unsigned i = 0, e = I.getNumArgOperands(); i != e; ++i) {
+      const Type* T = I.getArgOperand(i)->getType();
+      for (po_iterator<const Type*> i = po_begin(T),
+                                    e = po_end(T);
+                                    i != e; ++i) {
+        if (i->isFloatingPointTy()) {
+          MMI.setCallsExternalVAFunctionWithFloatingPointArguments(true);
+          break;
+        }
+      }
+    }
+  }
+
   const char *RenameFn = 0;
   if (Function *F = I.getCalledFunction()) {
     if (F->isDeclaration()) {
@@ -5027,25 +5047,6 @@
       }
     }
 
-    // See if any floating point values are being passed to this external
-    // function. This is used to emit an undefined reference to fltused on
-    // Windows.
-    MachineModuleInfo &MMI = DAG.getMachineFunction().getMMI();
-    if (F->isVarArg() &&
-        !MMI.callsExternalVAFunctionWithFloatingPointArguments()) {
-      for (unsigned i = 0, e = I.getNumArgOperands(); i != e; ++i) {
-        const Type* T = I.getArgOperand(i)->getType();
-        for (po_iterator<const Type*> i = po_begin(T),
-                                      e = po_end(T);
-                                      i != e; ++i) {
-          if (i->isFloatingPointTy()) {
-            MMI.setCallsExternalVAFunctionWithFloatingPointArguments(true);
-            break;
-          }
-        }
-      }
-    }
-
     // Check for well-known libc/libm calls.  If the function is internal, it
     // can't be a library call.
     if (!F->hasLocalLinkage() && F->hasName()) {