[llvm-commits] [llvm] r116823 - in /llvm/trunk/test: MC/ELF/ Scripts/

[Jason Kim]

On Tue, Oct 19, 2010 at 7:59 PM, Rafael Espíndola
<rafael.espindola at gmail.com> wrote:
>> +FormatOutput=hex
>
> This is dead, no?

Yes. I'll cut it.

>
>>     e_shnum = f.read16()
>> -    print "('e_shnum', %d)" % e_shnum
>> +    print "('e_shnum', %s)" % common_dump.HexDump(e_shnum)
>
> If printing with fixed sizes, we should probably print with the actual sizes...

Hmm, good point. But it requires churning the tests once again.
I'll tackle it same time that I tackle the macho-dump - to make all
hex numbers in test files consistent), since it will be a lot of
similar changes across the test files.

>
> Cheers,
> Rafael
>