[llvm-commits] [PATCH] MCFragments Clean Up

[Rafael Espindola]

> Thanks. Please let me know what you think.

I think I like it.

I was about to suggest making the new methods pure virtual in
MCFragment, but tried and noticed that the ilist tries to construct a
sentinel with that type. Pity.

ComputeFragmentSize is called from only one place and we know offset
is valid in there. I don't think we need PendingLayout.

The patch is a bit big and moves functions to a new file. How about
splitting it up? I have attached a first patch that just moves
ComputeFragmentSize to MCFragment and renames it ComputeSize.

If Daniel is OK with the direction your patch is going I would suggest
first committing the attached patch, then just moving the MCFragments
methods to a new file (you don't need all the includes btw) and then
actually doing the refactoring.

> - David M

Cheers,
-- 
Rafael Ávila de Espíndola
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ComputeSize.patch
Type: text/x-patch
Size: 4466 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20101017/1c21d142/attachment.bin>