[llvm-commits] [PATCH][Target/PTX] Add lower return and argument

[Che-Liang Chiou]

Hi Rafael,

Thanks for the comments.

PTX 2.0 spec (release on Jan 2010) says that varargs is not supported
yet.  I will replace those asserts with errors.  If there are no other
comments from others, I will submit the code.  Thanks.

Regards,
Che-Liang

On Wed, Oct 13, 2010 at 10:46 PM, Rafael Espindola <espindola at google.com> wrote:
> On 12 October 2010 23:24, Che-Liang Chiou <clchiou at gmail.com> wrote:
>> Re-send this patch in case no one noticed.
>
> I am not familiar with PTX, but since this patch is all in that
> backend, it is probably OK. I think my only comment is that some of
> the asserts should be errors. For example, varargs are not support or
> just not implemented yet? If not supported it should probably be an
> error. That way you still get an error on builds without assertions.
>
> Cheers,
> --
> Rafael Ávila de Espíndola
>