[llvm-commits] [PATCH] va_arg alignment type

Rafael Espindola espindola at google.com
Wed Oct 13 13:09:05 PDT 2010


On 13 October 2010 15:02, David Meyer <pdox at google.com> wrote:
> Rafael,
> The default on X86-32 is 4-byte alignment for doubles and long long (both in
> structs and on the stack).
> (gcc has the flag -malign-double to increase alignment to 8-bytes).

Yes, just realized that. One case that you can use for testing this
patch is  "<2 x i64>". Without your patch it should be aligned to 16
bytes, but with your patch it will be aligned to 8 on x86-64.

Also note that adding s:32 to your target description will align
everything on the call frame to 32 bits. I hope that is what you want.
If so I will commit your patch with a test using <2 x i64>.

> - David M

Cheers,
-- 
Rafael Ávila de Espíndola




More information about the llvm-commits mailing list