[llvm-commits] request to fix commit r116145

Chris Lattner clattner at apple.com
Mon Oct 11 19:18:10 PDT 2010


Thanks, fixed in r116288

-Chris

On Oct 11, 2010, at 5:22 PM, pageexec at freemail.hu wrote:

> this commit:
> 
> r116145 | abramo | 2010-10-09 06:51:06 +0200 (Sat, 09 Oct 2010) | 1 line
> 
> Fixed __builtin_constant_p return type.
> 
> made a mistake:
> 
> -BUILTIN(__builtin_constant_p, "Us.", "nc")
> +BUILTIN(__builtin_constant_p, "is.", "nc")
> 
> in that it made the first argument of the builtin 'short' whereas it
> could be anything (compiling the linux kernel will show how badly this
> manifests ;), so i think the correct line should be simply:
> 
> +BUILTIN(__builtin_constant_p, "i.", "nc")
> 
> cheers,
> 
>  PaX Team
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits




More information about the llvm-commits mailing list