[llvm-commits] [PATCH]: fixing clang Targets.cpp for PPC

[Roman Divacky]

On Thu, Oct 07, 2010 at 01:28:34PM -0400, Rafael Espindola wrote:
> On 5 October 2010 12:21, Roman Divacky <rdivacky at freebsd.org> wrote:
> > hi,
> >
> > the attached patch fixes two things
> >
> > 1) it defines the width/alignment of bool to be 32 (on Darwin)
> > ?? and 8 everywhere else
> >
> > 2) it changes the definition of va list declaration on ppc32
> > ?? for sysv/eabi ABIs
> >
> > this patch was developed by FreeBSD PowerPC developer Nathan
> > Whitehorn and enabled him to compile most of FreeBSD.
> 
> I am not very familiar with this code, but can't you just create a
> FreeBSDPPCTargetInfo  (or SYSVPPCTargetInfo) and declare the methods
> there?

this is not FreeBSD specific. what would be the advantage of doing
it via class vs simple if() ?