[llvm-commits] [Review request] test: adding triplets and FileCheck-ize for cygming(and msvc)

NAKAMURA Takumi geek4civic at gmail.com
Tue Oct 5 22:59:29 PDT 2010


Anton and Michael, good afternoon.

Excuse me, I missed patches attached at last post.

Thank you all for comments. I can show you improved ones, though, I am
still yet working in progress.
Checked on CentOS5(x86-64) and mingw.


> * 0002(29 files) -mtriple=x86_64-linux
>  It was needed for incompatibility among win64 and others.
>  They have been already FileCheck-ized.

* 0001 h-registers-0.ll

I added multiple actions for x86_64-(linux|mingw32|win32).
The sequences in @qux* is shorter on win32 than on linux, and I gave
up to write generalized pattern for them.

* 0004 (21 files)

I reverted triplets and rewrote pattern to match also Win64 ABI on x86-64.

* 0007 v2f32.ll

I rewrote patterns, but I guess it might be working in progress...
( CHECK would be not scanned on it)

* 0003 vec_cast.ll
I filed it as PR8311. It would not be executable with codegen/win64.
May I add XFAIL: mingw,win32 if this issue will be fixed soon?

* 0002 (5 files)
They have not been changed since last patch(0002).

 - fast-isel-cmp-branch.ll
   It is a test with invoke instruction.
 - red-zone.ll
   It would be nonsense on win64.
 - sse-commute.ll
   It was test for PR. I don't think we can see "expected" output.
 - sse-minmax.ll
 - xor.ll
   I am tired to rewrite them for win64 :(
   Please anyone, help me!


> * 0003(18 files) FileCheck-ize

* 0005 (5 files)
 I rewrote them more strict with FileCheck.

* 0006 (13 files)
 No changes since last 0003.


...Takumi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0007-v2f32.patch
Type: application/octet-stream
Size: 1055 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20101006/d735fb6e/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-test-CodeGen-X86-h-registers-0.ll-Add-the-pattern-ch.patch
Type: application/octet-stream
Size: 2497 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20101006/d735fb6e/attachment-0001.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-test-CodeGen-X86-Add-explicit-mtriple-x86_64-linux.patch
Type: application/octet-stream
Size: 3187 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20101006/d735fb6e/attachment-0002.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-test-CodeGen-X86-vec_cast.ll-Add-explicit-mtriple-x8.patch
Type: application/octet-stream
Size: 806 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20101006/d735fb6e/attachment-0003.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-test-CodeGen-X86-Rewrite-to-match-also-Win64-ABI-on-.patch
Type: application/octet-stream
Size: 20276 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20101006/d735fb6e/attachment-0004.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-test-FileCheck-ize.-except-CodeGen-X86.patch
Type: application/octet-stream
Size: 5130 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20101006/d735fb6e/attachment-0005.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-FileCheck-ize-20101004.patch
Type: application/octet-stream
Size: 7683 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20101006/d735fb6e/attachment-0006.obj>


More information about the llvm-commits mailing list