[llvm-commits] [Review request] test: adding triplets and FileCheck-ize for cygming(and msvc)

[Michael Spencer]

On Mon, Oct 4, 2010 at 12:27 AM, NAKAMURA Takumi <geek4civic at gmail.com> wrote:
> Good afternoon, guys!
>
> I have many patches for tests. At first, I post 6 patchesets I think
> they would be simpler.
> Please give me any comments.
> Feel free for everyone to improve my patches and commit in yourself.
>
> Thank you in advance, ...Takumi

Thank you for working on all these. The main problem I have is with
changing the tripples. This is not a real fix for the tests. The tests
need to be changed to either support both Windows style x86[-64] code
and Linux/Darwin, or we need separate tests for them. Just changing
the tripple masks the problem.

FileCheck has rather advanced facilities for regular expressions and
variables. Most of the differences seem to be register choice due to
the calling conventions that Windows uses.

> ps. All tests pass on llvm/cygmingw with my other patches remained.
>
>
> * Principle
>
>  - FileCheck-ize everything I touched.
>  - Add appropriate triplets as "-mtriple=i686-linux" and
> "-mtriple=x86_64-linux".
>
> * 0001(1 file) -mtriple=i686-linux
>
>  It was needed for Cygwin and Mingw.

See above, and this test passes for me on pure Windows.

> * 0002(29 files) -mtriple=x86_64-linux
>
>  It was needed for incompatibility among win64 and others.
>  They have been already FileCheck-ized.

See above.

> * 0003(18 files) FileCheck-ize

When replacing a grep line followed by count, you need to add a:

CHECK-NOT: <same-as-the-checks-above>

If you don't, you're not checking the greater than case.

> [snip...]

I'll review 4-6 later today, but they have many of the same problems above.

- Michael Spencer