[llvm-commits] [poolalloc] r115192 - in /poolalloc/trunk/test/dsa/extern: extern.ll extern2.ll extern3.ll extern_global.ll

Will Dietz wdietz2 at illinois.edu
Thu Sep 30 12:47:19 PDT 2010


Author: wdietz2
Date: Thu Sep 30 14:47:19 2010
New Revision: 115192

URL: http://llvm.org/viewvc/llvm-project?rev=115192&view=rev
Log:
Update extern tests to reflect that External no longer implies incomplete.
(Making these fail on current SVN)

Modified:
    poolalloc/trunk/test/dsa/extern/extern.ll
    poolalloc/trunk/test/dsa/extern/extern2.ll
    poolalloc/trunk/test/dsa/extern/extern3.ll
    poolalloc/trunk/test/dsa/extern/extern_global.ll

Modified: poolalloc/trunk/test/dsa/extern/extern.ll
URL: http://llvm.org/viewvc/llvm-project/poolalloc/trunk/test/dsa/extern/extern.ll?rev=115192&r1=115191&r2=115192&view=diff
==============================================================================
--- poolalloc/trunk/test/dsa/extern/extern.ll (original)
+++ poolalloc/trunk/test/dsa/extern/extern.ll Thu Sep 30 14:47:19 2010
@@ -13,9 +13,9 @@
 ;RUN: dsaopt %s -dsa-bu -analyze -verify-flags "main:ptr-IE"
 ;RUN: dsaopt %s -dsa-bu -analyze -verify-flags "main:ptrViaExtern+IE"
 
-;RUN: dsaopt %s -dsa-td -analyze -verify-flags "main:ptrExtern+IE"
+;RUN: dsaopt %s -dsa-td -analyze -verify-flags "main:ptrExtern-I+E"
 ;RUN: dsaopt %s -dsa-td -analyze -verify-flags "main:ptr-IE"
-;RUN: dsaopt %s -dsa-td -analyze -verify-flags "main:ptrViaExtern+IE"
+;RUN: dsaopt %s -dsa-td -analyze -verify-flags "main:ptrViaExtern-I+E"
 
 ;RUN: dsaopt %s -dsa-cbu -analyze -verify-flags "main:ptrExtern+IE"
 ;RUN: dsaopt %s -dsa-cbu -analyze -verify-flags "main:ptr-IE"
@@ -25,9 +25,9 @@
 ;RUN: dsaopt %s -dsa-eq -analyze -verify-flags "main:ptr-IE"
 ;RUN: dsaopt %s -dsa-eq -analyze -verify-flags "main:ptrViaExtern+IE"
 
-;RUN: dsaopt %s -dsa-eqtd -analyze -verify-flags "main:ptrExtern+IE"
+;RUN: dsaopt %s -dsa-eqtd -analyze -verify-flags "main:ptrExtern-I+E"
 ;RUN: dsaopt %s -dsa-eqtd -analyze -verify-flags "main:ptr-IE"
-;RUN: dsaopt %s -dsa-eqtd -analyze -verify-flags "main:ptrViaExtern+IE"
+;RUN: dsaopt %s -dsa-eqtd -analyze -verify-flags "main:ptrViaExtern-I+E"
 
 target datalayout = "e-p:64:64:64-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:64:64-f32:32:32-f64:64:64-v64:64:64-v128:128:128-a0:0:64-s0:64:64-f80:128:128-n8:16:32:64"
 target triple = "x86_64-unknown-linux-gnu"

Modified: poolalloc/trunk/test/dsa/extern/extern2.ll
URL: http://llvm.org/viewvc/llvm-project/poolalloc/trunk/test/dsa/extern/extern2.ll?rev=115192&r1=115191&r2=115192&view=diff
==============================================================================
--- poolalloc/trunk/test/dsa/extern/extern2.ll (original)
+++ poolalloc/trunk/test/dsa/extern/extern2.ll Thu Sep 30 14:47:19 2010
@@ -1,28 +1,28 @@
 ;Here we get a pointer from an external function and pass it to a callee.
 ;We then test that the flags on that pointer are set appropriately.
 ;RUN: dsaopt %s -dsa-local -analyze -verify-flags "main:ptr+IE"
-;RUN: dsaopt %s -dsa-local -analyze -verify-flags "takesPointer:ptr+IE"
+;RUN: dsaopt %s -dsa-local -analyze -verify-flags "takesPointer:ptr+I-E"
 
 ;RUN: dsaopt %s -dsa-bu -analyze -verify-flags "main:ptr+IE"
-;RUN: dsaopt %s -dsa-bu -analyze -verify-flags "takesPointer:ptr+IE"
+;RUN: dsaopt %s -dsa-bu -analyze -verify-flags "takesPointer:ptr+I-E"
 
-;RUN: dsaopt %s -dsa-td -analyze -verify-flags "main:ptr+IE"
-;RUN: dsaopt %s -dsa-td -analyze -verify-flags "takesPointer:ptr+IE"
+;RUN: dsaopt %s -dsa-td -analyze -verify-flags "main:ptr-I+E"
+;RUN: dsaopt %s -dsa-td -analyze -verify-flags "takesPointer:ptr-I+E"
 
 ;RUN: dsaopt %s -dsa-cbu -analyze -verify-flags "main:ptr+IE"
-;RUN: dsaopt %s -dsa-cbu -analyze -verify-flags "takesPointer:ptr+IE"
+;RUN: dsaopt %s -dsa-cbu -analyze -verify-flags "takesPointer:ptr+I-E"
 
 ;RUN: dsaopt %s -dsa-eq -analyze -verify-flags "main:ptr+IE"
-;RUN: dsaopt %s -dsa-eq -analyze -verify-flags "takesPointer:ptr+IE"
+;RUN: dsaopt %s -dsa-eq -analyze -verify-flags "takesPointer:ptr+I-E"
 
-;RUN: dsaopt %s -dsa-eqtd -analyze -verify-flags "main:ptr+IE"
-;RUN: dsaopt %s -dsa-eqtd -analyze -verify-flags "takesPointer:ptr+IE"
+;RUN: dsaopt %s -dsa-eqtd -analyze -verify-flags "main:ptr-I+E"
+;RUN: dsaopt %s -dsa-eqtd -analyze -verify-flags "takesPointer:ptr-I+E"
 
 
 target datalayout = "e-p:64:64:64-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:64:64-f32:32:32-f64:64:64-v64:64:64-v128:128:128-a0:0:64-s0:64:64-f80:128:128-n8:16:32:64"
 target triple = "x86_64-unknown-linux-gnu"
 
-define i32 @takesPointer(i32* nocapture %ptr) nounwind readonly {
+define internal i32 @takesPointer(i32* nocapture %ptr) nounwind readonly {
 entry:
   %0 = load i32* %ptr, align 4                    ; <i32> [#uses=1]
   ret i32 %0

Modified: poolalloc/trunk/test/dsa/extern/extern3.ll
URL: http://llvm.org/viewvc/llvm-project/poolalloc/trunk/test/dsa/extern/extern3.ll?rev=115192&r1=115191&r2=115192&view=diff
==============================================================================
--- poolalloc/trunk/test/dsa/extern/extern3.ll (original)
+++ poolalloc/trunk/test/dsa/extern/extern3.ll Thu Sep 30 14:47:19 2010
@@ -1,5 +1,5 @@
 ; ModuleID = 'extern.c'
-;This tests the various cases that could involve incompleteness due
+;This tests the various cases that could involve lack of 'knowsAll' due
 ;to external code, and additionally verifies these flags are NOT set
 ;on internal functions.
 target datalayout = "e-p:64:64:64-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:64:64-f32:32:32-f64:64:64-v64:64:64-v128:128:128-a0:0:64-s0:64:64-f80:128:128-n8:16:32:64"
@@ -10,9 +10,10 @@
 declare noalias i8* @malloc(i64) nounwind
 declare void @free(i8*) nounwind
 
-;This should be marked incomplete and external due to the
+;This should be marked external due to the
 ;unification-based nature of DSA.
-;RUN: dsaopt %s -dsa-td -analyze -verify-flags "getPointer:ptr+IE"
+;(this function does not have internal linkage)
+;RUN: dsaopt %s -dsa-td -analyze -verify-flags "getPointer:ptr+E-I"
 define i32* @getPointer() nounwind {
 entry:
   %0 = tail call noalias i8* @malloc(i64 4) nounwind ; <i8*> [#uses=1]
@@ -22,7 +23,7 @@
 
 ;This should be marked incomplete and external due to the
 ;unification-based nature of DSA.
-;RUN: dsaopt %s -dsa-td -analyze -verify-flags "takesPointer:ptr+IE"
+;RUN: dsaopt %s -dsa-td -analyze -verify-flags "takesPointer:ptr+E-I"
 define i32 @takesPointer(i32* %ptr) nounwind {
 entry:
   %0 = load i32* %ptr, align 4                    ; <i32> [#uses=1]
@@ -52,8 +53,8 @@
   ret i32 0
 }
 
-;RUN: dsaopt %s -dsa-td -analyze -verify-flags "checkExterns:get+IE"
-;RUN: dsaopt %s -dsa-td -analyze -verify-flags "checkExterns:take+IE"
+;RUN: dsaopt %s -dsa-td -analyze -verify-flags "checkExterns:get+E-I"
+;RUN: dsaopt %s -dsa-td -analyze -verify-flags "checkExterns:take+E-I"
 define void @checkExterns() nounwind {
   %get = tail call i32* ()* @getPointerExtern() nounwind ; <i32*> [#uses=0]
   %1 = tail call noalias i8* @malloc(i64 4) nounwind ; <i8*> [#uses=2]
@@ -63,8 +64,8 @@
   ret void
 }
 
-;RUN: dsaopt %s -dsa-td -analyze -verify-flags "checkExternals:get+IE"
-;RUN: dsaopt %s -dsa-td -analyze -verify-flags "checkExternals:take+IE"
+;RUN: dsaopt %s -dsa-td -analyze -verify-flags "checkExternals:get+E-I"
+;RUN: dsaopt %s -dsa-td -analyze -verify-flags "checkExternals:take+E-I"
 define void @checkExternals() nounwind {
 entry:
   %get = tail call i32* ()* @getPointer() nounwind ; <i32*> [#uses=0]

Modified: poolalloc/trunk/test/dsa/extern/extern_global.ll
URL: http://llvm.org/viewvc/llvm-project/poolalloc/trunk/test/dsa/extern/extern_global.ll?rev=115192&r1=115191&r2=115192&view=diff
==============================================================================
--- poolalloc/trunk/test/dsa/extern/extern_global.ll (original)
+++ poolalloc/trunk/test/dsa/extern/extern_global.ll Thu Sep 30 14:47:19 2010
@@ -1,17 +1,17 @@
 ; ModuleID = 'extern_global.c'
 ;This tests how DSA handles external globals and their completeness in TD.
 
-; Externally visible globals should be incomplete
-;RUN: dsaopt %s -dsa-td -analyze -verify-flags globalInt+GIE
-; Externally visible global and what it points to should be incomplete
-;RUN: dsaopt %s -dsa-td -analyze -verify-flags globalIntPtr+GIE
-;RUN: dsaopt %s -dsa-td -analyze -verify-flags globalIntPtr:0+GIE
-; Externally visible global and what it points to should be incomplete,
+; Externally visible globals should be marked external, but complete
+;RUN: dsaopt %s -dsa-td -analyze -verify-flags globalInt+GE-I
+; Externally visible global and what it points to should be complete/external
+;RUN: dsaopt %s -dsa-td -analyze -verify-flags globalIntPtr+GE-I
+;RUN: dsaopt %s -dsa-td -analyze -verify-flags globalIntPtr:0+GE-I
+; Externally visible global and what it points to should be complete/external
 ; this time with a struct and point to some stack memory...
-;RUN: dsaopt %s -dsa-td -analyze -verify-flags globalStructWithPointers+GIE
-;RUN: dsaopt %s -dsa-td -analyze -verify-flags globalStructWithPointers:8+IE
-;RUN: dsaopt %s -dsa-td -analyze -verify-flags globalStructWithPointers:8:8+IE
-;RUN: dsaopt %s -dsa-td -analyze -verify-flags main:s+IES
+;RUN: dsaopt %s -dsa-td -analyze -verify-flags globalStructWithPointers+GE-I
+;RUN: dsaopt %s -dsa-td -analyze -verify-flags globalStructWithPointers:8+E-I
+;RUN: dsaopt %s -dsa-td -analyze -verify-flags globalStructWithPointers:8:8+E-I
+;RUN: dsaopt %s -dsa-td -analyze -verify-flags main:s+ES-I
 ; Globals that aren't marked 'external' shouldn't be incomplete (or external)
 ;RUN: dsaopt %s -dsa-td -analyze -verify-flags normalGlobal+G-IE
 ;RUN: dsaopt %s -dsa-td -analyze -verify-flags internalGlobal+G-IE





More information about the llvm-commits mailing list