[llvm-commits] [patch][RFC] Correctly produce R_X86_64_32 or R_X86_64_32S

[Rafael Espindola]

> Hi Rafael,
>
> How is reloc_signed_4byte different than FK_Data_4?  Assuming that there is a good reason, please improve the documentation in X86FixupKinds.h for it, and commit.

The difference is that it marks a relocation that will be sign
extended at runtime. If I understand it correctly, this was not need
for MachO because all relocations that do sign extension there are
also PIC. That is not the case on ELF where we have signed and
unsigned 32->64 bits relocations (R_X86_64_32S and R_X86_64_32) that
are not PIC.

 Thanks!
>
> -Chris


Cheers,
-- 
Rafael Ávila de Espíndola