[llvm-commits] [PATCH] Re: [LLVMdev] Questions on ARMInstrInfo.td and MC/ARM/ELF

[Jim Grosbach]

Looks great! Please commit.

(and yes, it's definitely a nop for binary file emitters. Unified syntax just refers to the mnemonics used in .s files.)

On Sep 29, 2010, at 7:05 PM, Jason Kim wrote:

> Tiny patch for proof-of-concept cleanup of ARMAsmPrinter::EmitStartOfAsmFile()
> Small test for sanity check of resulting ARM .s file.
> Tested against -r115126
> 
> DiffView:   http://codereview.chromium.org/3551007
> 
> Thanks for reading!
> 
> -Jason
> 
> On Wed, Sep 29, 2010 at 5:33 PM, Jason Kim <jasonwkim at google.com> wrote:
>> On Wed, Sep 29, 2010 at 4:42 PM, Chris Lattner <clattner at apple.com> wrote:
>>> 
>>> I'm not sure what you mean.  The MCStreamer interface should have methods for all possible directives that can be sent to a .s file.  The problem here has nothing to do with text output, it is that we don't have a way to send the ".syntax unified" directive down a streamer.  The right fix is to add this support to MCStreamer.
>> 
>> Ahh! Okay. makes sense now. I'll send a small patch shortly.
>> Thanks
>> 
>> -jason
>> 
>>> 
>>> -Chris
>>> 
>>> 
>> 
> <arm-mc-elf-s03a-r115126.patch>