[llvm-commits] [llvm] r115038 - /llvm/trunk/lib/Target/ARM/ARMAsmPrinter.cpp

Chris Lattner clattner at apple.com
Wed Sep 29 15:53:30 PDT 2010


On Sep 29, 2010, at 8:23 AM, Jim Grosbach wrote:

> Author: grosbach
> Date: Wed Sep 29 10:23:40 2010
> New Revision: 115038
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=115038&view=rev
> Log:
> One Printer to rule them all, One Printer to find them,
> One Printer to lower them all and in the back end bind them.

Awesome, please dead code eliminate printInstruction and all the stuff it transitively calls.  Most of the "print operand" methods on ARMAsmPrinter can be removed now.  I think the only ones that need to stay around are the ones used by inline asm support.

The #include "ARMGenAsmWriter.inc" can also be removed.  Once that's done, this hack be be resolved in ARMInstPrinter.cpp:

#define MachineInstr MCInst
#define ARMAsmPrinter ARMInstPrinter  // FIXME: REMOVE.
#include "ARMGenAsmWriter.inc"
#undef MachineInstr
#undef ARMAsmPrinter

-Chris



More information about the llvm-commits mailing list