[llvm-commits] [llvm] r114856 - in /llvm/trunk/lib/Target/ARM: ARMELFWriterInfo.cpp ARMELFWriterInfo.h ARMSubtarget.h ARMTargetMachine.cpp ARMTargetMachine.h CMakeLists.txt

Rafael EspĂ­ndola rafael.espindola at gmail.com
Tue Sep 28 19:10:42 PDT 2010


> That is, just revert the portions of the patch which changed the ARM target and change the X86 target to implement these bits in the same way the ARM target does them.

That works and a patch implementing it is attached (factor.patch). I
am not sure if I agree that the "ARM way" is better since it
introduces more code duplication:

98 insertions(+), 77 deletions(-)

A somewhat hackish (can be improved someone likes it) patch that goes
the other way is also attached (factor2.patch). I like it a bit more
since it reduces duplication among the targetmachine implementations:

70 insertions(+), 120 deletions(-)

Cheers,
Rafael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: factor.patch
Type: text/x-patch
Size: 15687 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20100928/cd52face/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: factor2.patch
Type: text/x-patch
Size: 29697 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20100928/cd52face/attachment-0001.bin>


More information about the llvm-commits mailing list