[llvm-commits] Initial cut of ARM MC ELF emitter (PATCH)

Jim Grosbach grosbach at apple.com
Mon Sep 27 10:31:48 PDT 2010


It's much improved, but theres still one thing from my original comments that needs fixing.

The most recent patch still contains the bits moving the TargetData information into the base ARMBaseTargetMachine class from the ARMTargetMachine and ThumbTargetMachine classes. That's not appropriate. That sort of information is what the subclasses are there for. Please undo those changes.

-Jim

On Sep 27, 2010, at 10:02 AM, Rafael Espindola wrote:

> I think the patch is fine. Jim, any last comments before I commit it?
> 
> Cheers,
> -- 
> Rafael Ávila de Espíndola





More information about the llvm-commits mailing list