[llvm-commits] [PATCH] Possible bug fix in LegalizeDAG.cpp

Rafael Espindola espindola at google.com
Mon Sep 27 10:07:17 PDT 2010


On 24 September 2010 10:09, Edmund Grimley-Evans
<Edmund.Grimley-Evans at arm.com> wrote:
> I don't have a test case, but the original code looks suspicious and none of the regression tests fails for me when I make this change.
>
> On the other hand, see the comment a few lines above the altered line ...
>

The code is really strange, but I am not familiar with it to be sure
it is wrong. There is the Node->getNumValues() following by
Tmp1.getValue that you noticed. There is also the "e == 1" if in a
loop where e is constant! :-(

Cheers,
--
Rafael Ávila de Espíndola




More information about the llvm-commits mailing list