[llvm-commits] [llvm] r114747 - in /llvm/trunk: CMakeLists.txt cmake/modules/AddLLVM.cmake unittests/CMakeLists.txt utils/unittest/CMakeLists.txt

[Óscar Fuentes]

Michael Spencer <bigcheesegs at gmail.com> writes:

[snip]

>> But if you want to speed-up the VS build you could investigate why
>> tblgen is so slow on Windows. The time it takes to process the files
>> associated to the X86 target is quite larger than the required for
>> building the examples.
>
> tblgen seems fast to me. Where exactly are you seeing these slowdowns?

Well, just looking at the build output on the console. It took several
minutes to build the tablegen files for the X86 LLVM target. I'm using
VMWare, so there may be the problem.

[snip]

>> What we could do is simply
>>
>> if( LLVM_INCLUDE_TOOLS )
>>  add_subdirectory(tools)
>> endif()
>>
>> and add to the documentation of LLVM_BUILD_TOOLS a note about it being
>> conditioned by LLVM_INCLUDE_TOOLS (both on the definition of the
>> variable and on the html file.) Likewise for EXAMPLES.
>
> Did you take a look at my patch? LLVM_INCLUDE_X should be conditioned
> by LLVM_BUILD_X.

LLVM_BUILD_X means "If ON, add the targets under X to the ALL target,
else keep them as standalone targets." Your LLVM_INCLUDE_X means "If ON,
process the CMakeLists.txt files under X, else ignore them." Obviously
it doesn't make sense to decide if X is added to ALL when its
CMakeLists.txt are being ignored. So setting LLVM_INCLUDE_X to OFF makes
the setting of LLVM_BUILD_X irrelevant.

>> But all this may be irrelevant if the command "cmake --build ." works
>> for you as it works for me. In that case simply revert the commit and
>> you are done.
>
> I really would prefer this, but apparently the build bot doesn't like it :(.

So using nmake/jom is not a feasible option?