[llvm-commits] [LLVMdev] RFC: change build order (or location) of LLVMHello plugin

[NAKAMURA Takumi]

A trivial patch is attached. Checked on x86_64-centos5, ppc64-f12 and
cygming with both ENABLE_SHARED.

I think it would be better eg. the directory plugins/ should be had.

good afternoon...Takumi


2010/9/6 NAKAMURA Takumi <geek4civic at gmail.com>:
> Good evening, Michael.
>
> 2010/9/5 Michael Spencer <bigcheesegs at gmail.com>:
>> Do you know what the exact problem is? It would be best to fix the
>> Makefile instead of moving it. And sense it is a transformation, the
>> build system is broken if you _have_ to move it.
>
> I am sorry, I don't understand what *the exact problem" is.
> I can describe facts;
>
>  - Hello is the only LOADABLE_MODULE under lib/
>  - Other plugin, eg. tools/bugpoint-passes, can be built.
>
> ...Takumi
>
-------------- next part --------------
diff --git a/Makefile b/Makefile
index ae650b7..77fc833 100644
--- a/Makefile
+++ b/Makefile
@@ -31,7 +31,7 @@ ifeq ($(BUILD_DIRS_ONLY),1)
   OPTIONAL_DIRS :=
 else
   DIRS := lib/System lib/Support utils lib/VMCore lib tools/llvm-shlib \
-          tools/llvm-config tools runtime docs unittests
+          tools/llvm-config tools lib/Transforms/Hello runtime unittests
   OPTIONAL_DIRS := projects bindings
 endif
 
@@ -45,6 +45,9 @@ include $(LEVEL)/Makefile.config
 
 ifneq ($(ENABLE_SHARED),1)
   DIRS := $(filter-out tools/llvm-shlib, $(DIRS))
+  ifneq (,$(filter $(HOST_OS), Cygwin MingW Minix))
+    DIRS := $(filter-out lib/Transforms/Hello, $(DIRS))
+  endif
 endif
 
 ifeq ($(MAKECMDGOALS),libs-only)
diff --git a/lib/Transforms/Makefile b/lib/Transforms/Makefile
index e527be2..e560113 100644
--- a/lib/Transforms/Makefile
+++ b/lib/Transforms/Makefile
@@ -8,13 +8,6 @@
 ##===----------------------------------------------------------------------===##
 
 LEVEL = ../..
-PARALLEL_DIRS = Utils Instrumentation Scalar InstCombine IPO Hello
-
-include $(LEVEL)/Makefile.config
-
-# No support for plugins on windows targets
-ifeq ($(HOST_OS), $(filter $(HOST_OS), Cygwin MingW Minix))
-  PARALLEL_DIRS := $(filter-out Hello, $(PARALLEL_DIRS))
-endif
+PARALLEL_DIRS = Utils Instrumentation Scalar InstCombine IPO
 
 include $(LEVEL)/Makefile.common