[llvm-commits] [llvm] r113875 - /llvm/trunk/lib/Target/ARM/AsmPrinter/ARMInstPrinter.cpp

Chris Lattner clattner at apple.com
Tue Sep 14 16:37:09 PDT 2010


On Sep 14, 2010, at 4:32 PM, Jim Grosbach wrote:

>> I am not really sure if I want to encourage this or not, but the registers are in fact sorted numerically, so you can go:
>> 
>> unsigned DReg = ARM::D0 + 2*(QReg - ARM::Q0)
>> 
>> This requires at least 'assert(Q0+15 == Q15)'
>> 
>> Either way is gross.
>> 
> 
> Yeah. It's definitely ugly all the way around. I'm planning to refactor the way we handle these dregpair operands as part of this whole process with MC inst printing, and hopefully I'll be able to get rid of this ugliness altogether. We shall see. In the meantime, I think I prefer the longer, but more explicit, ugly rather than the short and tricky ugly. 

I agree :)

-Chris





More information about the llvm-commits mailing list