[llvm-commits] [PATCH][MS][Review request] - Fix index lit tests failing on Windows

Francois Pichet pichet2000 at gmail.com
Sat Sep 11 10:16:59 PDT 2010


This patch fixes all the index lit tests failing on Win32.

lit index tests were failing on windows because GetPreamblePCHPath was
returning a empty string.
Returning a empty string because when python spawn c-index-test.exe
neither "TMPDIR", "TEMP" or "TMP" are defined as environment
variables.

Then GetPreamblePCHPath  returning "" created a complicated chain of
events leading to a crash. Probably the code should be more robust.

I am not sure if this can be defined as trivial change i can commit
without review?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: index_test_win32_fix.patch
Type: application/octet-stream
Size: 546 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20100911/e3e52167/attachment.obj>


More information about the llvm-commits mailing list