[llvm-commits] [patch][mc] Add support for .uleb

Rafael Espindola espindola at google.com
Thu Sep 9 18:06:52 PDT 2010


> Awesome!  One major comment: please add this to generic code.  The darwin assembler also supports this directive, we just never got around to implementing it.

Moved. It is still supporting only absolute expressions. I left
HasLEB128 unchanged in X86MCAsmInfoDarwin because I don't know if it
needs full support or just absolute expressions are sufficient.

> We should also add a "emit uleb/sleb" value in MCStreamer, because these directives don't require an immediate, it can be a symbolic value (like a label difference).

This looks bigger than the current patch. Is it OK to add support for
absolute expressions first and come back after more of the low hanging
ELF bits are done?

> -Chris

Cheers,
-- 
Rafael Ávila de Espíndola
-------------- next part --------------
A non-text attachment was scrubbed...
Name: leb128.patch
Type: text/x-patch
Size: 7547 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20100909/8f39dcc1/attachment.bin>


More information about the llvm-commits mailing list