[llvm-commits] [llvm] r108932 - in /llvm/trunk: include/llvm/PassRegistry.h lib/VMCore/Pass.cpp lib/VMCore/PassRegistry.cpp

Owen Anderson resistor at mac.com
Tue Sep 7 12:49:45 PDT 2010


On Sep 5, 2010, at 3:43 PM, Chris Lattner wrote:
>> +namespace {
> 
> Please only use namespaces for classes.  For globals and functions, just use 'static' like the coding standards say:
> http://llvm.org/docs/CodingStandards.html#micro_anonns

'static' is not legal in this instance, since we need to pass the address of cleanupPassRegistry() to the ManagedCleanup object.

--Owen



More information about the llvm-commits mailing list