[llvm-commits] Issue with Win64 local area stack offset

[Jan Sjodin]

I see, that is unfortunate. I will take a look at why this happens. Right now I 
believe this is because the patch is incomplete and there is some interaction 
with the callee code that is not taken into consideration. The shadow area 
should still be allocated before the return address on the stack.

- Jan



----- Original Message ----
> From: Anton Korobeynikov <anton at korobeynikov.info>
> To: Jan Sjodin <jan_sjodin at yahoo.com>
> Cc: llvm-commits at cs.uiuc.edu
> Sent: Fri, September 3, 2010 6:42:39 AM
> Subject: Re: [llvm-commits] Issue with Win64 local area stack offset
> 
> Hello, Jan
> 
> > Any comments about the revised patch? Ok for someone to commit?
> The patch is invalid. First of all, make sure it does not break "make check".
> Right now it does and one of the failed tests clearly indicates the
> problem - the shadow space is allocated in the wrong place and calls
> might clobber spills of the callee which will be really hard to find
> in real-world apps.
> 
> -- 
> With best regards, Anton Korobeynikov
> Faculty of Mathematics and Mechanics, Saint Petersburg State University
>