[llvm-commits] [llvm] r112869 - in /llvm/trunk/lib/Target/X86: AsmPrinter/X86InstComments.cpp X86ShuffleDecode.h

[Bruno Cardoso Lopes]

On Thu, Sep 2, 2010 at 3:22 PM, Chris Lattner <clattner at apple.com> wrote:
>
> On Sep 2, 2010, at 3:07 PM, Bruno Cardoso Lopes wrote:
>
>> On Thu, Sep 2, 2010 at 3:01 PM, Chris Lattner <clattner at apple.com> wrote:
>>>
>>> On Sep 2, 2010, at 2:51 PM, Bruno Cardoso Lopes wrote:
>>>
>>>> Author: bruno
>>>> Date: Thu Sep  2 16:51:11 2010
>>>> New Revision: 112869
>>>>
>>>> URL: http://llvm.org/viewvc/llvm-project?rev=112869&view=rev
>>>> Log:
>>>> Move decoding of insertps back to avoid unused warnings in x86 isel lowering, and fix movlhps/movhlps to decode 4 elements shuffles
>>>
>>> What warning?  If it is about unused functions, just mark the function 'static inline'.
>>
>> A warning at the code I'm going to check-in, in X86ISelLowering, all
>> functions are going to be used but the insertps, which is not a
>> shuffle.
>
> If you mark them all 'inline' that warning will go away.  insertps is a (funny) shuffle :), it would be nice to keep everything together in the header.
>
> -Chris

Yep! :)

-- 
Bruno Cardoso Lopes
http://www.brunocardoso.cc