[llvm-commits] [llvm] r112597 - in /llvm/trunk: include/llvm/CodeGen/Passes.h lib/CodeGen/DwarfEHPrepare.cpp lib/CodeGen/LLVMTargetMachine.cpp

[Bill Wendling]

On Aug 31, 2010, at 2:05 AM, Duncan Sands wrote:

> Author: baldrick
> Date: Tue Aug 31 04:05:06 2010
> New Revision: 112597
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=112597&view=rev
> Log:
> Stop using the dom frontier in DwarfEHPrepare by not promoting alloca's
> any more.  I plan to reimplement alloca promotion using SSAUpdater later.
> It looks like Bill's URoR logic really always needs domtree, so the pass
> now always asks for domtree info.
> 
I'm fine with this, but please do the alloca promotion using SSAUpdater soon. Otherwise my horrible hack won't work for all of the cases I need it to. As John mentioned, I need to do reachability and not dominance. I'll fix it so that the DomTree stuff isn't needed.

Thanks.
-bw