[llvm-commits] [llvm] r111895 - in /llvm/trunk: lib/AsmParser/LLParser.cpp lib/AsmParser/LLParser.h lib/Bitcode/Writer/ValueEnumerator.cpp lib/Bitcode/Writer/ValueEnumerator.h test/Feature/metadata.ll

[Devang Patel]

On Aug 24, 2010, at 11:30 AM, Dan Gohman wrote:

> 
> On Aug 24, 2010, at 11:21 AM, Devang Patel wrote:
> 
>> Dan,
>> 
>> I expected parser to reject following but it does not.
>> 
>> define void @foo(i32 %x) {
>> store i32 0, i32* null, !whatever !{i32 %tmp}
>> %tmp = add i32 %x, %x
>> ret void
>> }
> 
> It doesn't reject this either:
> 
> define void @foo() {
> entry:
>  call void @llvm.dbg.value(metadata !{i32* %t}, i64 0, metadata !"hello")
>  %t = alloca i32
>  ret void
> }
> 
> declare void @llvm.dbg.value(metadata, i64, metadata) nounwind readnone
> 
> Should it?

IMO, yes.
-
Devang