[llvm-commits] [llvm] r111914 - /llvm/trunk/lib/AsmParser/LLParser.cpp

Dan Gohman gohman at apple.com
Tue Aug 24 07:35:45 PDT 2010


Author: djg
Date: Tue Aug 24 09:35:45 2010
New Revision: 111914

URL: http://llvm.org/viewvc/llvm-project?rev=111914&view=rev
Log:
Add a comment explaining why this code doesn't just call
ParseMetadataValue.

Modified:
    llvm/trunk/lib/AsmParser/LLParser.cpp

Modified: llvm/trunk/lib/AsmParser/LLParser.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/AsmParser/LLParser.cpp?rev=111914&r1=111913&r2=111914&view=diff
==============================================================================
--- llvm/trunk/lib/AsmParser/LLParser.cpp (original)
+++ llvm/trunk/lib/AsmParser/LLParser.cpp Tue Aug 24 09:35:45 2010
@@ -1134,6 +1134,10 @@
     if (ParseToken(lltok::exclaim, "expected '!' here"))
       return true;
 
+    // This code is similar to that of ParseMetadataValue, however it needs to
+    // have special-case code for a forward reference; see the comments on
+    // ForwardRefInstMetadata for details. Also, MDStrings are not supported
+    // at the top level here.
     if (Lex.getKind() == lltok::lbrace) {
       ValID ID;
       if (ParseMetadataListValue(ID, PFS))





More information about the llvm-commits mailing list