[llvm-commits] JIT: Emitting a debug location after an instruction

[nicolas geoffray]

On Mon, Aug 23, 2010 at 8:57 PM, Jeffrey Yasskin <jyasskin at google.com>wrote:
>
> I'm not sure processDebugLoc does what you need it to, even with your
> changes. It only records an address when the DebugLoc changes, and
> that's not guaranteed to happen exactly on the call
> MachineInstruction. (Unless you've done something to ensure it does?)
>

Each call instruction and only call instructions have metadata associated to
it. So I am sure emitting the debug location after emitting the call
instructions work for my case.


> Do you have a unit test that shows this works in all cases?
>

Not sure about the "all cases", but at least it is working as intended for
me and these hooks (emitting before or after) were already present before my
changes.


>
> Mapping return addresses to metadata seems like more of a job for the
> GC system, but that's not implemented for the JIT, so I can't very
> well say to use it instead. :-/
>

Indeed, doing it in the GC system would also work, but the changes would be
way less straightforward than this simple change in the JITemitter.

Nicolas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20100823/a0692559/attachment.html>