[llvm-commits] [PATCH] Bugpoint/Support: Fix llvm::FindExecutable not looking for files ending with .exe

Michael Spencer bigcheesegs at gmail.com
Mon Aug 23 06:28:40 PDT 2010


On Mon, Aug 23, 2010 at 6:06 AM, NAKAMURA Takumi <geek4civic at gmail.com> wrote:
> Michael-san,
> Chris-san,
>
> An alternative patch is attached. Would you like a look into this?
>
> I thought that patch was incomplete.
> for example, assume path="c:/path/to/foo" and the executable
> "c:/path/to/foo.exe" exists.
>
> With that patch, path.canExecute() returns true.
> But Win32 CreateProcess("c:/path/to/foo", ...) fails even if
> "c:/path/to/foo.exe" exists.
> (CreateProcess does not add suffix.exe when directory part exists)
>
> I got succeeded to let test/BugPoint pass on mingw.
>
>
> Thank you in advance, ... Takumi
>
>
> ps. feel free to rewrite or modify my comments in this patch.
>

Takumi is correct that my patch is not complete. It fails on windows
also if the llvm tools are not in PATH. I'll take a look at your patch
and thanks for finding this problem and fixing it.

- Michael Spencer



More information about the llvm-commits mailing list