[llvm-commits] [llvm] r111285 - in /llvm/trunk/lib/CodeGen: LiveIntervalAnalysis.cpp PHIElimination.cpp PHIElimination.h

[Evan Cheng]

On Aug 17, 2010, at 2:11 PM, Jakob Stoklund Olesen wrote:

> 
> On Aug 17, 2010, at 2:00 PM, Evan Cheng wrote:
> 
>> Author: evancheng
>> Date: Tue Aug 17 16:00:37 2010
>> New Revision: 111285
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=111285&view=rev
>> Log:
>> PHI elimination shouldn't require machineloopinfo since it's used at -O0. Move the requirement to LiveIntervalAnalysis instead. Note this does not change the number of times machineloopinfo is computed.
> 
> Thanks!
> 
> Note that both SimpleRegisterCoalescing and CalcSpillWeights require LoopInfo, so you may be able to get away with only AU.addPreserved<MachineLoopInfo>() in LiveIntervalAnalysis.

That's what I thought at first but it didn't work as expected.

> 
> Does this mean that we are only calculating LoopInfo once now? That's awesome.

No. Tail duplication and if-conversion are not preserving it.

Evan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20100817/072bbb2f/attachment.html>