[llvm-commits] [llvm] r111260 - /llvm/trunk/lib/Target/ARM/Disassembler/ARMDisassemblerCore.cpp

[Jim Grosbach]

Me either, 'til now. I was looking to make sure other new code I'm working on didn't have warnings and happened to notice this one. :)

On Aug 17, 2010, at 11:16 AM, Bob Wilson wrote:

> Thanks, Jim!  I hadn't noticed the warning.
> 
> On Aug 17, 2010, at 11:00 AM, Jim Grosbach wrote:
> 
>> Author: grosbach
>> Date: Tue Aug 17 13:00:41 2010
>> New Revision: 111260
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=111260&view=rev
>> Log:
>> explicitly handle no-op cases for clarity. Fixes clang warning.
>> 
>> Modified:
>>   llvm/trunk/lib/Target/ARM/Disassembler/ARMDisassemblerCore.cpp
>> 
>> Modified: llvm/trunk/lib/Target/ARM/Disassembler/ARMDisassemblerCore.cpp
>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/ARM/Disassembler/ARMDisassemblerCore.cpp?rev=111260&r1=111259&r2=111260&view=diff
>> ==============================================================================
>> --- llvm/trunk/lib/Target/ARM/Disassembler/ARMDisassemblerCore.cpp (original)
>> +++ llvm/trunk/lib/Target/ARM/Disassembler/ARMDisassemblerCore.cpp Tue Aug 17 13:00:41 2010
>> @@ -459,6 +459,9 @@
>>  if (ShImm != 0)
>>    return;
>>  switch (ShOp) {
>> +  case ARM_AM::no_shift:
>> +  case ARM_AM::rrx:
>> +    break;
>>  case ARM_AM::lsl:
>>    ShOp = ARM_AM::no_shift;
>>    break;
>> 
>> 
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>