[llvm-commits] [llvm] r111230 - /llvm/trunk/include/llvm/MC/MCObjectWriter.h

[Benjamin Kramer]

On 17.08.2010, at 17:16, Daniel Dunbar wrote:

> Hi Benjamin,
> 
> On Tue, Aug 17, 2010 at 6:55 AM, Benjamin Kramer
> <benny.kra at googlemail.com> wrote:
>> Author: d0k
>> Date: Tue Aug 17 08:55:45 2010
>> New Revision: 111230
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=111230&view=rev
>> Log:
>> Micro-optimize MCObjectWriter to do a byteswap if necessary and then write the
>> whole integer to the stream instead of doing byte-sized writes.
> 
> Gross, IMHO. Adding Host dependencies to portable code, which isn't
> performance sensitive, seems like a bad trade to me.

When rummaging in ELFObjectWriter I saw the gross code this generates and made a workaround.
I will revert if it's not perf sensitive and less grossness makes you sleep better at night :)

It would be nice if we put all the endian conversion stuff in a common place and make it really fast,
but MCObjectWriter doesn't seem to be the right place for that.