[llvm-commits] [llvm] r110493 - in /llvm/trunk: include/llvm/Support/ConstantRange.h lib/Support/ConstantRange.cpp

Chris Lattner clattner at apple.com
Fri Aug 6 22:30:39 PDT 2010


On Aug 6, 2010, at 5:42 PM, Owen Anderson wrote:

> Author: resistor
> Date: Fri Aug  6 19:42:06 2010
> New Revision: 110493
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=110493&view=rev
> Log:
> Add a convenience constructor.
...

> +++ llvm/trunk/lib/Support/ConstantRange.cpp Fri Aug  6 19:42:06 2010
> @@ -21,6 +21,7 @@
> //
> //===----------------------------------------------------------------------===//
> 
> +#include "llvm/Constants.h"
> #include "llvm/Support/ConstantRange.h"

This should be removed, but even if it were to stay, it is not the right #include order.  Always include the .cpp file's corresponding header first.

-Chris







More information about the llvm-commits mailing list