[llvm-commits] [PATCH] Fix CMake build

Óscar Fuentes ofv at wanadoo.es
Tue Aug 3 10:46:01 PDT 2010


Peter Collingbourne <peter at pcc.me.uk>
writes:

>> These patches fix certain aspects of the CMake build for me, but I
>> wasn't 100% certain they are the right thing to do.  In particular I
>> am not sure how the significant changes to LLVMLibDeps.cmake relate
>> to the changes I made.
>> 
>> OK to commit?
>
> I also updated the patches (and the changes to LLVMLibDeps.cmake do
> not seem so significant now).  The name changes to the PIC16 and XCore
> libraries do not seem to be needed now (I was unable to reproduce the
> error I got before) but it might still be worthwhile to make that
> change for the sake of consistency with the Makefile build and the
> other CodeGen libraries.

I just updated the PIC16 and XCore library names and associated
dependencies.

For the other patch, I see nothing objectionable on the CMake
changes. Others have to comment on the C++ part.




More information about the llvm-commits mailing list