[llvm-commits] [llvm] r109035 - in /llvm/trunk/lib/Target/X86: X86ISelLowering.cpp X86InstrInfo.cpp

Anton Korobeynikov anton at korobeynikov.info
Wed Jul 21 14:01:12 PDT 2010


Hello, Nate

> xmm6-15 are marked as clobbered by call instructions on win64 even though they aren't.
They in fact are. Consider reading e.g.
http://msdn.microsoft.com/en-us/library/9z1stfyw.aspx

> -    if (!X86::VR128RegClass.contains(Reg) && !isWin64) {
> +    if (!X86::VR128RegClass.contains(Reg)) {
This change is incorrect. This way you'll get stuff like "push xmm6",
which is invalid instruction.
Please revert.

-- 
With best regards, Anton Korobeynikov
Faculty of Mathematics and Mechanics, Saint Petersburg State University




More information about the llvm-commits mailing list