[llvm-commits] [llvm] r107678 - in /llvm/trunk: lib/Target/X86/AsmPrinter/X86MCInstLower.cpp test/CodeGen/X86/2010-07-06-DbgCrash.ll

[Devang Patel]

Valgrind on my mac is not reporting this error. Is it possible for any one with linux  box to shed a little light here ?
-
Devang

On Jul 16, 2010, at 8:36 AM, Daniel Dunbar wrote:

> Hi Devang,
> 
> The valgrind buildbot is back online, and is reporting an error with
> this test. Can you take a look:
>  http://google1.osuosl.org:8011/builders/llvm-i686-linux-vg_leak/builds/1076/steps/test-llvm/logs/2010-07-06-dbgcrash.ll
> 
> - Daniel
> 
> On Tue, Jul 6, 2010 at 11:18 AM, Devang Patel <dpatel at apple.com> wrote:
>> Author: dpatel
>> Date: Tue Jul  6 13:18:32 2010
>> New Revision: 107678
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=107678&view=rev
>> Log:
>> Fix PR7545 crash.
>> 
>> Added:
>>    llvm/trunk/test/CodeGen/X86/2010-07-06-DbgCrash.ll
>> Modified:
>>    llvm/trunk/lib/Target/X86/AsmPrinter/X86MCInstLower.cpp
>> 
>> Modified: llvm/trunk/lib/Target/X86/AsmPrinter/X86MCInstLower.cpp
>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/AsmPrinter/X86MCInstLower.cpp?rev=107678&r1=107677&r2=107678&view=diff
>> ==============================================================================
>> --- llvm/trunk/lib/Target/X86/AsmPrinter/X86MCInstLower.cpp (original)
>> +++ llvm/trunk/lib/Target/X86/AsmPrinter/X86MCInstLower.cpp Tue Jul  6 13:18:32 2010
>> @@ -505,7 +505,6 @@
>>   O << V.getName();
>>   O << " <- ";
>>   // Frame address.  Currently handles register +- offset only.
>> -  assert(MI->getOperand(0).isReg() && MI->getOperand(3).isImm());
>>   O << '['; printOperand(MI, 0, O); O << '+'; printOperand(MI, 3, O);
>>   O << ']';
>>   O << "+";
>> @@ -517,8 +516,9 @@
>>   MachineLocation Location;
>>   assert (MI->getNumOperands() == 7 && "Invalid no. of machine operands!");
>>   // Frame address.  Currently handles register +- offset only.
>> -  assert(MI->getOperand(0).isReg() && MI->getOperand(3).isImm());
>> -  Location.set(MI->getOperand(0).getReg(), MI->getOperand(3).getImm());
>> +
>> +  if (MI->getOperand(0).isReg() && MI->getOperand(3).isImm())
>> +    Location.set(MI->getOperand(0).getReg(), MI->getOperand(3).getImm());
>>   return Location;
>>  }
>> 
>> 
>> Added: llvm/trunk/test/CodeGen/X86/2010-07-06-DbgCrash.ll
>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/2010-07-06-DbgCrash.ll?rev=107678&view=auto
>> ==============================================================================
>> --- llvm/trunk/test/CodeGen/X86/2010-07-06-DbgCrash.ll (added)
>> +++ llvm/trunk/test/CodeGen/X86/2010-07-06-DbgCrash.ll Tue Jul  6 13:18:32 2010
>> @@ -0,0 +1,29 @@
>> +; RUN: llc -O0 -relocation-model pic -o /dev/null
>> +; PR7545
>> + at .str = private constant [4 x i8] c"one\00", align 1 ; <[4 x i8]*> [#uses=1]
>> + at .str1 = private constant [4 x i8] c"two\00", align 1 ; <[5 x i8]*> [#uses=1]
>> + at C.9.2167 = internal constant [2 x i8*] [i8* getelementptr inbounds ([4 x i8]* @.str, i64 0, i64 0), i8* getelementptr inbounds ([4 x i8]* @.str1, i64 0, i64 0)]
>> +!38 = metadata !{i32 524329, metadata !"pbmsrch.c", metadata !"/Users/grawp/LLVM/test-suite/MultiSource/Benchmarks/MiBench/office-stringsearch", metadata !39} ; [ DW_TAG_file_type ]
>> +!39 = metadata !{i32 524305, i32 0, i32 1, metadata !"pbmsrch.c", metadata !"/Users/grawp/LLVM/test-suite/MultiSource/Benchmarks/MiBench/office-stringsearch", metadata !"4.2.1 (Based on Apple Inc. build 5658) (LLVM build 9999)", i1 true, i1 false, metadata !"", i32 0} ; [ DW_TAG_compile_unit ]
>> +!46 = metadata !{i32 524303, metadata !38, metadata !"", metadata !38, i32 0, i64 64, i64 64, i64 0, i32 0, metadata !47} ; [ DW_TAG_pointer_type ]!97 = metadata !{i32 524334, i32 0, metadata !38, metadata !"main", metadata !"main", metadata !"main", metadata !38, i32 73, metadata !98, i1 false, i1 true, i32 0, i32 0, null, i1 false, i1 false, null} ; [ DW_TAG_subprogram ]!101 = metadata !{[2 x i8*]* @C.9.2167}
>> +!47 = metadata !{i32 524324, metadata !38, metadata !"char", metadata !38, i32 0, i64 8, i64 8, i64 0, i32 0, i32 6} ; [ DW_TAG_base_type ]
>> +!97 = metadata !{i32 524334, i32 0, metadata !38, metadata !"main", metadata !"main", metadata !"main", metadata !38, i32 73, metadata !98, i1 false, i1 true, i32 0, i32 0, null, i1 false, i1 false, null} ; [ DW_TAG_subprogram ]
>> +!98 = metadata !{i32 524309, metadata !38, metadata !"", metadata !38, i32 0, i64 0, i64 0, i64 0, i32 0, null, metadata !99, i32 0, null} ; [ DW_TAG_subroutine_type ]
>> +!99 = metadata !{metadata !100}
>> +!100 = metadata !{i32 524324, metadata !38, metadata !"int", metadata !38, i32 0, i64 32, i64 32, i64 0, i32 0, i32 5} ; [ DW_TAG_base_type ]
>> +!101 = metadata !{[2 x i8*]* @C.9.2167}
>> +!102 = metadata !{i32 524544, metadata !103, metadata !"find_strings", metadata !38, i32 75, metadata !104} ; [ DW_TAG_auto_variable ]
>> +!103 = metadata !{i32 524299, metadata !97, i32 73, i32 0} ; [ DW_TAG_lexical_block ]
>> +!104 = metadata !{i32 524289, metadata !38, metadata !"", metadata !38, i32 0, i64 85312, i64 64, i64 0, i32 0, metadata !46, metadata !105, i32 0, null} ; [ DW_TAG_array_type ]
>> +!105 = metadata !{metadata !106}
>> +!106 = metadata !{i32 524321, i64 0, i64 1332}    ; [ DW_TAG_subrange_type ]
>> +!107 = metadata !{i32 73, i32 0, metadata !103, null}
>> +
>> +define i32 @main() nounwind ssp {
>> +bb.nph:
>> +  tail call void @llvm.dbg.declare(metadata !101, metadata !102), !dbg !107
>> +  ret i32 0, !dbg !107
>> +}
>> +
>> +declare void @llvm.dbg.declare(metadata, metadata) nounwind readnone
>> +
>> 
>> 
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>