[llvm-commits] [llvm] r107922 - in /llvm/trunk: lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp test/CodeGen/X86/leaf-fp-elim.ll

[Evan Cheng]

On Jul 8, 2010, at 3:38 PM, Bill Wendling wrote:

> Author: void
> Date: Thu Jul  8 17:38:02 2010
> New Revision: 107922
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=107922&view=rev
> Log:
> Extension of r107506. Make sure that we don't mark a function as having a call
> if the inline ASM doesn't need a stack frame.
> 
> Added:
>    llvm/trunk/test/CodeGen/X86/leaf-fp-elim.ll
> Modified:
>    llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp
> 
> Modified: llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp?rev=107922&r1=107921&r2=107922&view=diff
> ==============================================================================
> --- llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp (original)
> +++ llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp Thu Jul  8 17:38:02 2010
> @@ -300,7 +300,8 @@
>       for (MachineBasicBlock::const_iterator
>              II = MBB->begin(), IE = MBB->end(); II != IE; ++II) {
>         const TargetInstrDesc &TID = TM.getInstrInfo()->get(II->getOpcode());
> -        if (II->isInlineAsm() || (TID.isCall() && !TID.isReturn())) {
> +        if ((II->isInlineAsm() && II->getOperand(1).getImm()) ||

What is II->getOperand(1).getImm() checking? Can you add a comment?

Evan

> +            (TID.isCall() && !TID.isReturn())) {
>           MFI->setHasCalls(true);
>           goto done;
>         }
> 
> Added: llvm/trunk/test/CodeGen/X86/leaf-fp-elim.ll
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/leaf-fp-elim.ll?rev=107922&view=auto
> ==============================================================================
> --- llvm/trunk/test/CodeGen/X86/leaf-fp-elim.ll (added)
> +++ llvm/trunk/test/CodeGen/X86/leaf-fp-elim.ll Thu Jul  8 17:38:02 2010
> @@ -0,0 +1,30 @@
> +; RUN: llc < %s -disable-non-leaf-fp-elim -relocation-model=pic -mtriple=x86_64-apple-darwin | FileCheck %s
> +; <rdar://problem/8170192>
> +target datalayout = "e-p:64:64:64-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:64:64-f32:32:32-f64:64:64-v64:64:64-v128:128:128-a0:0:64-s0:64:64-f80:128:128-n8:16:32:64"
> +target triple = "x86_64-apple-darwin11.0"
> +
> + at msg = internal global i8* null                   ; <i8**> [#uses=1]
> + at .str = private constant [2 x i8] c"x\00", align 1 ; <[2 x i8]*> [#uses=1]
> +
> +define void @test(i8* %p) nounwind optsize ssp {
> +
> +; No stack frame, please.
> +; CHECK:     _test
> +; CHECK-NOT: pushq %rbp
> +; CHECK-NOT: movq %rsp, %rbp
> +; CHECK:     InlineAsm Start
> +
> +entry:
> +  %0 = icmp eq i8* %p, null                       ; <i1> [#uses=1]
> +  br i1 %0, label %return, label %bb
> +
> +bb:                                               ; preds = %entry
> +  tail call void asm "mov $1, $0", "=*m,{cx},~{dirflag},~{fpsr},~{flags}"(i8** @msg, i8* getelementptr inbounds ([2 x i8]* @.str, i64 0, i64 0)) nounwind
> +  tail call void @llvm.trap()
> +  unreachable
> +
> +return:                                           ; preds = %entry
> +  ret void
> +}
> +
> +declare void @llvm.trap() nounwind
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits